Allow for a custom path and domain at the same time #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micha <[email protected]>
|
Just found a bug, so it's not ready to merge quite yet. Fixing it right now |
|
I did some mental gymnastics to get here. The issue I'm having is my fault, and the issue I mentioned is unrelated. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107
Hi! I ran into this issue when trying to combine a docs repo and a code repo into one monorepo. I did a quick fix with
action.shinvolving moving the check for$CUSTOM_DOMAINinto the if statement that checks for a custom config file path.I've tested these changes out, and they seem to work great. Here are the use cases I tested:
My testing environment is over at this repo.
Let me know if any changes are in order. Thanks!