Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nomaterial branch #253

Draft
wants to merge 29 commits into
base: nomaterial
Choose a base branch
from
Draft

Conversation

andi34
Copy link

@andi34 andi34 commented Jan 17, 2024

Fixes #227

  • Cherry-Picked applying commits from master branch to get in sync
  • updated Docker file:
    • use python:3.11-alpine3.18
    • removed unneeded run line
  • updated example for nomaterial action
  • install mkdocs by default, no need for an own requirements.txt now
  • updated action example to use checkout@v4

János Pásztor and others added 25 commits January 17, 2024 06:50
Signed-off-by: Michael Hausenblas <[email protected]>
Signed-off-by: Michael Hausenblas <[email protected]>
Since 1.18, the addition of ${GITHUB_DOMAIN:-github.com} make error occurs in execution of the workflow.

I propose to modify ; ${GITHUB_DOMAIN:-github.com} to ${GITHUB_DOMAIN:-'github.com'}

Source : https://tldp.org/LDP/abs/html/parameter-substitution.html
Issue ref : mhausenblas#87
Signed-off-by: Cristian Klein <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from v2.3.3 to v2.3.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.3...5a4ac90)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.4...v2.3.5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I found no reference how to install the required dependencies. This feature is already there but not documented, so I extended the README file.

Out of my view this resolves mhausenblas#12, mhausenblas#53 and mhausenblas#97

Signed-off-by: rekire <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.3.5...v2.4.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3.0.1.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2.4.0...v3.0.1)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Scott Robinson <[email protected]>

Signed-off-by: Scott Robinson <[email protected]>
Signed-off-by: Andreas Blaesius <[email protected]>
@andi34
Copy link
Author

andi34 commented Jan 17, 2024

Add also required mkdocs by default?

@andi34
Copy link
Author

andi34 commented Jan 17, 2024

It's not possible to override a default environment variable
@andi34 andi34 marked this pull request as draft September 5, 2024 18:41
@andi34
Copy link
Author

andi34 commented Sep 5, 2024

Made draft because of personal changes since this PR was never reviewed and no feedback given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.