-
Notifications
You must be signed in to change notification settings - Fork 5
grpc web prototype #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love deleting code. Thanks for the improvement!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot something
go.mod
Outdated
| ) | ||
|
|
||
| replace ( | ||
| github.com/soyuka/grpcweb => ../../projects/grpcweb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, but before we can merge, the go.mod will need to be fixed.
|
I think we should completely drop the websocket code as it is not supported nor recommended by grpcweb see https://github.com/grpc/grpc-web/blob/70268fa6e2e1c31949305bd6dc14098c821fef58/doc/streaming-roadmap.md?plain=1#L25 |
|
I'm good with removing it; I don't know anyone using that feature, and we're not bound to compatibility guarantees here (yet) since we clearly document this as experimental and subject to change. Anyway, this LGTM, or if we want to remove websockets now I can wait to merge this until that is ready 👍 |
|
I will test that and report :) |
|
Great! It's looking good now. Let me know when you're ready to merge. |
|
Tested at https://github.com/soyuka/caddy-grpc/tree/main/testdata Basically with {
grpc {
address :50051
}
}
localhost {
route {
grpc_web
reverse_proxy h2c://127.0.0.1:50051
}
} |
|
Awesome, lgtm. Thanks again!! |
This uses github.com/soyuka/grpcweb instead of improbable-eng/grpc-web as caddy already has the whole http layer.