Don't mutate headers in setUploadOptions

Enable ESLint rule to stop me from doing this again.
mhoran · Mar 10, 2024 · a16bd73 · a16bd73
1 parent c3ebea0
commit a16bd73
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.eslintrc b/.eslintrc
@@ -14,6 +14,7 @@
   "settings": { "react": { "version": "detect" } },
   "rules": {
     "eqeqeq": "error",
+    "no-param-reassign": ["error", { "props": true }],
     "@typescript-eslint/consistent-type-assertions": "error",
     "@typescript-eslint/no-unused-vars": [
       "error",

diff --git a/src/usecase/settings/UploadSettings.tsx b/src/usecase/settings/UploadSettings.tsx
@@ -88,7 +88,8 @@ const UploadSettings: React.FC<Props> = ({
     const { headers, ...rest } = uploadOptionsState;
     const headersObject = headers.reduce<Record<string, string>>(
       (headers, [headerName, headerValue]) => {
-        if (headerName && headerValue) headers[headerName] = headerValue;
+        if (headerName && headerValue)
+          return { ...headers, [headerName]: headerValue };
         return headers;
       },
       {}