Implement scrollToLine by checking "overridden" layouts #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While not currently used, position: absolute on the text element fixes height calculation. Move the opacity to the wrapper in case we need to measure anything else in the future.
Fixes for privacy manifest requirements.
Fixes for privacy manifest requirements.
Scroll to the target index in a loop until the layout returned by the layout manager isOverridden. This indicates that the target cell has actually been measured and can be scrolled to reliably. Similarly to FlatList, we must reset the internal measurement state via key prop to work around the layout manager indicating that the target index has been measured. This is because the prepended items may have invalidated the isOverridden indication for the given index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a suitable substitute for the lack of
onScrollToIndexFailedin FlashList.