Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a shadowy variable on code example #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid a shadowy variable on code example #28

wants to merge 1 commit into from

Conversation

cyrilf
Copy link

@cyrilf cyrilf commented Aug 30, 2017

Avoid the login variable to be shadowed in the example.

On the sagas.js file of the README example we can see:

import { login } from './actions'; // importing our action

and then

function* handleLoginSaga(action) {
  const { login, password } = action.payload;

So the login action is shadowed by the login from the payload.
Meaning that at the line yield put(login.success()); our code won't be happy.

Hope it helps 🌱

Avoid the `login` variable to be shadowed in the example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant