2722 popover menu toggle variant menu items cause accessibility error #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2722-popover-menu-toggle-variant-menu-items-cause-accessibility-error/web-components |
GCHQ-Developer-112
force-pushed
the
2722-popover-menu-toggle-variant-menu-items-cause-accessibility-error
branch
from
e5a0849 to
5f39c9f
Compare
GCHQ-Developer-112
force-pushed
the
2722-popover-menu-toggle-variant-menu-items-cause-accessibility-error
branch
from
5f39c9f to
3084bd5
Compare
GCHQ-Developer-112
force-pushed
the
v3.0.0/develop
branch
from
88e126d to
49484eb
Compare
GCHQ-Developer-741
force-pushed
the
v3.0.0/develop
branch
from
137312d to
be4d353
Compare
Update audit dates for March
chore(root): update audit dates - v3 cherry pick
Update docs.json with empty state theme prop
Update empty state to have theme prop to make use of light/dark theme
Readme cherry pick
Update tree view to prevent FOUC - set tree items visibility to hidden until loaded when inherited props from tree view used. Removed timeouts on truncation - tree view now truncates when ready rather than waiting 0.1 seconds to help reduce flashing.
…d items Update tree view truncation story to have expanded items - to show truncation working on nesting items.
Update data table empty state cypress image
Update empty state to have theme prop to make use of light/dark theme
Empty state theme prop
fix(canary-web-components): update tree view to improve FOUC
…ponent storybooks
…x accessibility issues Remove nested ic-button within the toggle variant of ic-menu-item to fix accessibility issues. Rename ic-popover-menu CSS tokens. Update tests and stories . #2722
…gle variant of ic-menu-item Uncomment Cypress accessibility tests that were previously failing . #2722
GCHQ-Developer-112
force-pushed
the
2722-popover-menu-toggle-variant-menu-items-cause-accessibility-error
branch
from
3084bd5 to
f68b257
Compare
ad9242
force-pushed
the
v3.0.0/develop
branch
from
fa8f16c to
8f687d3
Compare
GCHQ-Developer-299
force-pushed
the
v3.0.0/develop
branch
from
8d14ba9 to
566d663
Compare
MI6-255
force-pushed
the
v3.0.0/develop
branch
from
46015cc to
7cab72a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
ic-buttonwithin the toggle variant ofic-menu-itemto fix accessibility issues.ic-popover-menuCSS tokensRelated issue
#2722
Checklist
General
Testing
Accessibility