Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3284 ic back to top expose css variables to allow changing of x and y position #3286

Conversation

gd2910
Copy link
Contributor

@gd2910 gd2910 commented Mar 4, 2025

Summary of the changes

Exposes three CSS variables to allow a developer to more accurately customise the position of the ic-back-to-top component

Related issue

#3267

@gd2910 gd2910 force-pushed the 3284-ic-back-to-top-expose-css-variables-to-allow-changing-of-x-and-y-position branch from 1a690ff to 2f26bdc Compare March 4, 2025 13:30
@gd2910 gd2910 force-pushed the 3284-ic-back-to-top-expose-css-variables-to-allow-changing-of-x-and-y-position branch 7 times, most recently from fb4e67f to b0552d1 Compare March 6, 2025 16:36
gd2910 added 3 commits March 11, 2025 08:52
Storybook updated, unit tests added

2154
…ack-to-top

CSS props for x and y positions exposed on ic-back-to-top
…d x and y CSS values

Visual regression tests added for new IcBackToTop exposed x and y CSS values

3284
@gd2910 gd2910 force-pushed the 3284-ic-back-to-top-expose-css-variables-to-allow-changing-of-x-and-y-position branch from b0552d1 to b552056 Compare March 11, 2025 08:52
@gd2910 gd2910 marked this pull request as ready for review March 11, 2025 08:57
@GCHQ-Developer-530 GCHQ-Developer-530 merged commit eb82737 into v3.0.0/develop Mar 18, 2025
11 of 13 checks passed
@GCHQ-Developer-530 GCHQ-Developer-530 deleted the 3284-ic-back-to-top-expose-css-variables-to-allow-changing-of-x-and-y-position branch March 18, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants