-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3284 ic back to top expose css variables to allow changing of x and y position #3286
Merged
GCHQ-Developer-530
merged 3 commits into
v3.0.0/develop
from
3284-ic-back-to-top-expose-css-variables-to-allow-changing-of-x-and-y-position
Mar 18, 2025
Merged
3284 ic back to top expose css variables to allow changing of x and y position #3286
GCHQ-Developer-530
merged 3 commits into
v3.0.0/develop
from
3284-ic-back-to-top-expose-css-variables-to-allow-changing-of-x-and-y-position
Mar 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3284-ic-back-to-top-expose-css-variables-to-allow-changing-of-x-and-y-position/web-components |
packages/react/src/component-tests/IcBackToTop/IcBackToTopTestData.tsx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/ic-back-to-top/test/basic/ic-back-to-top.spec.tsx
Outdated
Show resolved
Hide resolved
1a690ff
to
2f26bdc
Compare
fb4e67f
to
b0552d1
Compare
Storybook updated, unit tests added 2154
…ack-to-top CSS props for x and y positions exposed on ic-back-to-top
…d x and y CSS values Visual regression tests added for new IcBackToTop exposed x and y CSS values 3284
b0552d1
to
b552056
Compare
packages/web-components/src/components/ic-back-to-top/ic-back-to-top.css
Show resolved
Hide resolved
GCHQ-Developer-741
approved these changes
Mar 12, 2025
GCHQ-Developer-530
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Exposes three CSS variables to allow a developer to more accurately customise the position of the ic-back-to-top component
Related issue
#3267