Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-components): [ic-button] remove 1px top and bottom margin fro… #3321

Open
wants to merge 3 commits into
base: v3.0.0/develop
Choose a base branch
from

Conversation

gd2910
Copy link
Contributor

@gd2910 gd2910 commented Mar 13, 2025

…m icon variant

[ic-button] remove 1px top and bottom margin from icon variant and regenerate affected baseline images

As part of this ticket while regenerating canary-react images I sorted the baseline images into directories.

2178

Copy link
Contributor

@gd2910 gd2910 changed the title fix(web-components): [ic-button] remove 1px top and bottom margin fro… DRAFT fix(web-components): [ic-button] remove 1px top and bottom margin fro… Mar 14, 2025
@gd2910 gd2910 force-pushed the 2178-margins-on-icon-buttons branch 4 times, most recently from a0bcdd2 to 74e8f5e Compare March 18, 2025 11:58
@gd2910 gd2910 changed the title DRAFT fix(web-components): [ic-button] remove 1px top and bottom margin fro… fix(web-components): [ic-button] remove 1px top and bottom margin fro… Mar 18, 2025
@gd2910 gd2910 force-pushed the 2178-margins-on-icon-buttons branch 4 times, most recently from 5e303ee to 4df30f5 Compare March 19, 2025 14:56
@gd2910 gd2910 marked this pull request as ready for review March 19, 2025 14:56
@gd2910 gd2910 force-pushed the 2178-margins-on-icon-buttons branch 6 times, most recently from 8c3db71 to 204c251 Compare March 24, 2025 13:31
gd2910 added 2 commits March 24, 2025 14:44
…m icon variant

[ic-button] remove 1px top and bottom margin from icon variant

2178
regenerate react baseline images
@gd2910 gd2910 force-pushed the 2178-margins-on-icon-buttons branch from 204c251 to 93f6c58 Compare March 24, 2025 14:44
regenerated baseline images into directories

2178
@gd2910 gd2910 force-pushed the 2178-margins-on-icon-buttons branch from f11158d to 2417107 Compare March 24, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant