fix(web-components): fix circular loading indicator showing as complete circle #3352
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te circle Fix issue with loading indicator where circular indeterminate variant was just displaying as a complete circle.
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/fix/loading-indicator-display-issue/web-components |
GCHQ-Developer-530
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixed issue which I noticed was introduced by my TypeScript strict mode PR where circular indeterminate variant of the loading indicator was just showing as a complete circle.
(I think the v3 develop branch has not updated properly so isn't showing the bug - look at a build on another PR if not)
Related issue
N/A