Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change shell command to generate masterkey #249

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

verdienansein
Copy link
Contributor

Pull Request Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

I changed the command to generate masterKey on shell for Mia-Platform chart installation. The one before usually errors with: tr: Illegal byte sequence.

PR Checklist

  • The commit message follows our guidelines included in the CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@fredmaggiowski
Copy link
Member

Already reviewed here: mia-platform/documentation#1024

Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski
Copy link
Member

@verdienansein I've tested the command on my shell (zsh on Mac OS) but it doesn't prompt any result 🤔

@verdienansein verdienansein merged commit 199fb97 into main Jan 24, 2024
2 checks passed
@verdienansein verdienansein deleted the doc/master-key-generation branch January 24, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants