Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/project iam commands #146

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Feat/project iam commands #146

merged 10 commits into from
Jan 26, 2024

Conversation

JGiola
Copy link
Member

@JGiola JGiola commented Jan 22, 2024

What this PR is for?

This PR will complete the IAM integration in the CLI. The last commands are the ones that are related to IAM access for projects and environments.

@JGiola JGiola requested a review from a team as a code owner January 22, 2024 13:45
@JGiola JGiola requested a review from davidebianchi January 22, 2024 13:45
internal/cmd/project/iam.go Outdated Show resolved Hide resolved
"github.com/spf13/cobra"
)

func RemoveroleCmd(options *clioptions.CLIOptions) *cobra.Command {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func RemoveroleCmd(options *clioptions.CLIOptions) *cobra.Command {
func RemoveRoleCmd(options *clioptions.CLIOptions) *cobra.Command {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

internal/iam/edit.go Show resolved Hide resolved
Copy link
Member

@davidebianchi davidebianchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidebianchi davidebianchi merged commit 05251da into main Jan 26, 2024
9 checks passed
@davidebianchi davidebianchi deleted the feat/project-iam-commands branch January 26, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants