Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage deploy pipeline error #237

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Conversation

fabioS24
Copy link
Contributor

Right now the miactl deploy command return ok even when the pipeline ends with failure.
Using this command in a pipeline would mean to have a job that failed its operation but in the UI is succeeded.

With this PR, when the deploy fails the command returns an error "pipeline failed".

@fabioS24 fabioS24 requested a review from a team as a code owner January 31, 2025 15:48
Copy link
Member

@JGiola JGiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JGiola
Copy link
Member

JGiola commented Feb 3, 2025

@fabioS24 can you add a new line to the CHANGELOG file for the feature?

@JGiola JGiola merged commit 8c68bb3 into main Feb 3, 2025
9 checks passed
@JGiola JGiola deleted the fix/IDP-2659-manage-deploy-error branch February 3, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants