Always use base dsm host to format camera live view paths

[ruimarinho]

Hi @mib1185,

This PR introduces a change which should make everyone's life just a little bit easier: when setting up this module, we have to provide a hostname or IP for the Synology DSM connection. However, due to a number of reasons — such as Docker network configuration, multiple NICs being used, reverse proxies and others — the actual camera live view URL will always return the IP or host configuration that Synology believes to be more adequate.

However, think about this: we, as module consumers, configure the hostname or IP based on what we know about our own network setup and routing, to eventually receive back an unexpected — and potentially unreachable — URL of a camera's live view.

In my opinion, we can magically fix this by replacing whatever hostname or IP Synology Surveillance Station returns with the base URL configured in the module. It is guaranteed to succeed since connectivity has been achieved already.

My particular network configuration involves a bit of an elaborate macvlan setup inside Docker on Synology DSM, which makes the originally returned IP become unreachable due to host <> container network limitations in this network topology.

Example:

Before

• Configure module to connect to nas.mywebsite.me.
• Connection succeeds, cameras are listed.
• Obtaining a camera live view URL yields rtsp://syno:[email protected]:554/Sms=1.unicast

After

• Configure module to connect to nas.mywebsite.me.
• Connection succeeds, cameras are listed.
• Obtaining a camera live view URL yields rtsp://syno:[email protected]:554/Sms=1.unicast

[ruimarinho]

@mib1185 is this something you could consider for the module?

[apires]

+1, even if added as a quirk

[mib1185]

Hi @ruimarinho

I think this should be optional, but not always.
To do so, the logic about overriding the life view path with the base url should be placed within the get_camera_live_view_path function of SynoSurveillanceStation and toggled by a additional argument like override_lifeview_base_url=False.

[mib1185]

see #137 (comment)