Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement _ pattern (#148) #150

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Implement _ pattern (#148) #150

merged 7 commits into from
Oct 30, 2023

Conversation

grisenti
Copy link
Contributor

@grisenti grisenti commented Oct 22, 2023 •
edited by liquidev
Loading

Closes #148.
Closes #151.

liquidev
liquidev requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@liquidev liquidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! I'm glad to see you willing to contribute code to Mica.

There are some minor nitpicks as well as more major reservations I have regarding the implementation, please address them before we proceed with merging into main.

src/ll/lexer.rs Outdated Show resolved Hide resolved
tests/language/tuple/destructuring/discard-element.test.mi Outdated Show resolved Hide resolved
src/ll/ast.rs Show resolved Hide resolved
src/ll/error.rs Outdated Show resolved Hide resolved
src/ll/codegen/tuples.rs Show resolved Hide resolved
tests/language/tuple/destructuring/discard-element.test.mi Outdated Show resolved Hide resolved
tests/language/variable/discard-declaration.test.mi Outdated Show resolved Hide resolved
src/ll/parser.rs Outdated Show resolved Hide resolved
src/ll/codegen/tuples.rs Show resolved Hide resolved
src/ll/codegen/assignment.rs Show resolved Hide resolved
@liquidev liquidev mentioned this pull request Oct 23, 2023
Closed
@liquidev liquidev mentioned this pull request Oct 30, 2023
Closed
@liquidev liquidev added this to the 0.8.0 milestone Oct 30, 2023
@liquidev
Copy link
Member

Alright, time to get this merged! Thank you once again for taking your time to contribute. I don't want to hold your contribution back so I'll clean up my remaining concerns on my own before 0.8.0 is released. Many thanks for doing some proper testing on records, it makes me a lot more confident it'll be a feature you can rely on.

@liquidev liquidev merged commit 5de5ca8 into mica-lang:main Oct 30, 2023
1 check passed
@liquidev liquidev mentioned this pull request Oct 30, 2023
Merged
liquidev added a commit that referenced this pull request Oct 30, 2023
@liquidev
_ pattern cleanup (#154)
f208754 
Implementing what I meant in some of my comments in #150.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liquidev liquidev liquidev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Record destructuring does not work correctly _ pattern
2 participants
@grisenti @liquidev