Update Manifest.toml for package updates #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chenwilliam77 Thanks for the PR! Sorry I missed it previously. Can you please re-review your update - does it still make sense to merge it in the current condition or are more updates needed as time has passed? |
|
Hi Micah, I did some googling, and I added a new commit removing Manifest.toml from version control. I think that's the current best practice for constructing packages since the Manifest.toml is the full dependency tree, which can differ across computers. I think you can merge my pull request now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Manifest was specifying an old version of HTTP.jl, which was preventing me from pulling data. I've rewritten the Manifest.toml so that it uses the newer versions of HTTP.jl.