Moodle 4.5 Plugin CI runs.

michael-milette · Jan 29, 2025 · 948768b · 948768b
1 parent fc86c12
commit 948768b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 10 deletions.
diff --git a/.github/workflows/moodle-ci.yml b/.github/workflows/moodle-ci.yml
@@ -16,7 +16,7 @@ jobs:
   # Set the job key. The key is displayed as the job name when a job name is not provided
   test:
     # Virtual environment to use.
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     # DB services you need for testing.
     services:
@@ -58,6 +58,19 @@ jobs:
         #   - php: '8.2'
         #     moodle-branch: 'main'
         #     database: 'mariadb'
+          # Moodle 4.5.x (MOODLE_405_STABLE).
+          - php: '8.3'
+            moodle-branch: 'MOODLE_405_STABLE'
+            database: 'pgsql'
+          - php: '8.3'
+            moodle-branch: 'MOODLE_405_STABLE'
+            database: 'mariadb'
+          - php: '8.2'
+            moodle-branch: 'MOODLE_405_STABLE'
+            database: 'mariadb'
+          - php: '8.1'
+            moodle-branch: 'MOODLE_405_STABLE'
+            database: 'pgsql'
           # Moodle 4.4.x (MOODLE_404_STABLE).
           - php: '8.3'
             moodle-branch: 'MOODLE_404_STABLE'
@@ -156,23 +169,16 @@ jobs:
         if: ${{ !cancelled() }}
         run: moodle-plugin-ci phplint
 
-      - name: PHP Copy/Paste Detector
-        continue-on-error: true # This step will show errors but will not fail
-        if: ${{ !cancelled() }}
-        run: moodle-plugin-ci phpcpd
-
       - name: PHP Mess Detector
         continue-on-error: true # This step will show errors but will not fail
         if: ${{ !cancelled() }}
         run: moodle-plugin-ci phpmd
 
       - name: Moodle Code Checker
-        continue-on-error: true # This step will show errors but will not fail
         if: ${{ !cancelled() }}
         run: moodle-plugin-ci phpcs --max-warnings 0
 
       - name: Moodle PHPDoc Checker
-        continue-on-error: true # This step will show errors but will not fail
         if: ${{ !cancelled() }}
         run: moodle-plugin-ci phpdoc --max-warnings 0
 

diff --git a/classes/text_filter.php b/classes/text_filter.php
@@ -4185,7 +4185,7 @@ function ($matches) use ($USER) {
                                 break;
                             case 'contains':
                                 // If the specified field contains the specified value.
-                                // Example:{ifprofile email contains "@example.com"}...{/ifprofile}.
+                                // Example:{ifprofile email contains "@xample.com"}...{/ifprofile}.
                                 if (strpos($profilefields[$fieldname]->value, $value) !== false) {
                                     $content = $matches[4][$key];
                                 }

diff --git a/lang/en/filter_filtercodes.php b/lang/en/filter_filtercodes.php
@@ -250,6 +250,6 @@
 $string['unenrolme'] = 'Unenrol me from this course';
 $string['verbose'] = 'Verbose';
 $string['wishlist'] = 'Wishlist';
-$string['wishlist_nocourses'] = 'No courses in the list';
 $string['wishlist_add'] = 'Add this course to the list';
+$string['wishlist_nocourses'] = 'No courses in the list';
 $string['wishlist_remove'] = 'Remove this course from the list';