-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next: ability to add nodes to the selected list #75
Open
klutometis
wants to merge
28
commits into
michael:master
Choose a base branch
from
klutometis:next
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist actions + async task with busy message for ui feedback
…ing if enabled (if option sorted is false, perhaps have the sortable re-inserted) + redesigned the cache system and bash operations + CSS cleanup and fully integrated theme roller for the list containers + added spanish translation (thanks hkadejo) did also renamed the translation files to reflect ui.multiselect file naming + input field now autosize to best fit depending on language selection + etc.
…emote node insertion with simple text lists + added another animation effect on node transfer + better management of batch process
… more than 1 multiselect present on same page + code cleanup (unused and debug vars) + added some todos
…relocated the branch homepage so the PHP would actually work
…page + added a new dependancy (blockUI). The code has grown in size, but has proven to be stable, even with a public API
…blockUI) + updated the demo page to control the widget externally. The code has grown, but proven to be stable, and relatively fast.
The nodeComparator is used on both list only if a callback is provided (there is no type check, so it's either boolean | Function -- should there be a setting to use the comparator on the selected/available/both items only?) Incremented to 0.4.32-y (because I wanted to) The sortable/droppable works as is, but implementation both way needs to be fixed.
Code needs to be cleaned a little... TODO : reorder <option> elements according to sortable selected order
There is a weird bug with IE (as usual) where dropped elements fly down the page before the item appears in the list... The code needs to be cleaned, and improved, but it's a start. modified: index.html modified: js/ui.multiselect.js modified: version.txt
…pe (corss-library compatibility) Modified the localisation strings to work with $.tmpl Added getters/setters + added a new error message (option readonly) Modified the demo page to display API and make it more dynamic (fixed some links also) Added some styles (needs to be cleaned) Added form.php to catch form actions and return feedback
…h "sortable:both" (best use with default options, or limiting to droppables, or none) Some speed improvements, although deselecting items is slowing than selecting... Added events: "messages" to handle errors, "selected" to handle selected items and "deselected" when they are deselected. Tweaked the demo page a little. TODO: - the search command still searches for option values, while I consider more and more making it use the option text instead and having something else to find an option text from it's key (perhaps: .multiselect('option', 'find', key) ?)
…odified the demo page to reflect latest development and added the version info and license info. Widget is almost ready for 1.0 state!
… (?) on the demo page API section. + Fixed a flaw in the _setBusy function. + Drag and drop may still happen on busy state, and it may become a bug... however it is not for the moment. + Little improvement in the selectedValue public method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When populating from a database, it may be the case that there are some pre-selected nodes; I'd like to be able to add these to the selected list.
I've added an argument to addOptions, to that end, `selected': that sets selected="selected" on the options; so that they get added to selectedList instead of availableList later on.