Update PROTOCOL-PDO.md #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-1 doesn't exist in UINT, so I converted them to what the value would be in the respective UINTs
|
I must admit that at least 4294967295 looks like a magic number. |
|
I agree with @denmaus, while you are technically correct that it's impossible to specify a negative number with an unsigned int, it does make it more clear what the values mean by just indicating a negative number. I prefer this clarity. Maybe a note below the table to indicate this might be better? |
|
Maybe: |
That's also fine I guess :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-1 doesn't exist in UINT, so I converted them to what the value would be in the respective UINTs