LRCI-5071 Fix AC Testing #2998
Open
LRCI-5071 Fix AC Testing #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests are executed on same server and they don't cleanup data it can generate this test to be flaky.
…OwnerViewPermission, and AddCategoryWithSiteMemberViewPermission to integration tests
…n CompanyThreadLocal
…ch is the SpSessionTerminationSamlPortalFilter having a valid companyId and session set in CompanyThreadLocal.
…the instance level. Make sure to set the previous values back after our test.
…e string, and get the session key directly from the samlSpSession object.
…st calling getInputStream() is enough to connect
…n isn't added earlier, the persistence layer will throw an exception, thus failing the test.
…as to what this test is for.
…cause this filter does not need configuration and allowing it to filter the SAML endpoints is harmless
❌ ci:test:analytics-cloud-acceptance - 0 out of 19 jobs passed in 1 hourClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: c0fe70e42b05ef5b2bc5d25bd127810e7a64eb7c ci:test:analytics-cloud-acceptance - 0 out of 19 jobs PASSED19 Failed Jobs:
For more details click here.Failures unique to this pull:
|
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#10588 Jenkins Report:jenkins-report.html Jenkins Suite:analytics-cloud-acceptance Pull Request:michaelhashimoto#2998 Testray Routine:EE Pull Request Testray Build:[master] ci:test:analytics-cloud-acceptance - michaelhashimoto > michaelhashimoto - PR#2998 - 2024-12-09[16:06:22] Testray Build ID:87993706 Testray Importer:publish-testray-report#25150 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#10589 Jenkins Report:jenkins-report.html Jenkins Suite:analytics-cloud-acceptance Pull Request:michaelhashimoto#2998 Testray Routine:EE Pull Request Testray Build:[master] ci:test:analytics-cloud-acceptance - michaelhashimoto > michaelhashimoto - PR#2998 - 2024-12-09[17:10:37] Testray Build ID:88076818 Testray Importer:publish-testray-report#25152 |
…t is no longer possible, as the GraphQL library that we are upgrading has implemented a security check that does not allow to include the parameter more than once in a Schema query, so we need to split the first query into two queries, first to get all the mutations and the second one to get the fields inside the top level query/mutation" The previous commit had removed some assertions
michaelhashimoto
force-pushed
the
master-ci-5071-rca-ac
branch
from
c324016 to
bd598d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LRCI-5071