blockSubscribe RPC Method

[ruiqic]

No description provided.

[michaelhly]

Hi, thanks for opening a PR! Would you mind fixing the lint issue and also writing a test?

You can run make lint to run the linter, and make format to format your code. Here is an example of a test:

solana-py/tests/integration/test_websockets.py

Lines 283 to 292 in 53adfce

	@pytest.mark.integration
	async def test_slot_subscribe(
	websocket: SolanaWsClientProtocol,
	slot_subscribed: None,
	):
	"""Test slot subscription."""
	main_resp = await websocket.recv()
	msg = main_resp[0]
	assert isinstance(msg, SlotNotification)
	assert msg.result.root >= 0

[ruiqic]

Hi, thanks for checking. I just added a simple test for slot and used make format to fix all black issues. Let me know.

[ruiqic]

Test not passing maybe because not all RPCs support this method:

UNSTABLE METHOD
This subscription is considered unstable and is only available if the validator was started with the --rpc-pubsub-enable-block-subscription flag. The format of this subscription may change in the future.
(https://solana.com/docs/rpc/websocket/blocksubscribe)

[michaelhly]

Hi @ruiqic. You can add the flag here:

solana-py/tests/docker-compose.yml

Line 11 in 53adfce

SOLANA_RUN_SH_VALIDATOR_ARGS=--rpc-pubsub-enable-vote-subscription

[michaelhly]

Also, would you mind reverting all the formatting changes not related to this PR?

[michaelhly]

Looks like we need to use _TX_ENCODING_TO_SOLDERS instead:

Suggested change

	encoding_to_use = None if encoding is None else _ACCOUNT_ENCODING_TO_SOLDERS[encoding]
	encoding_to_use = None if encoding is None else _TX_ENCODING_TO_SOLDERS[encoding]

solana-py/src/solana/rpc/core.py

Lines 93 to 99 in 53adfce

	_TX_ENCODING_TO_SOLDERS = {
	"binary": UiTransactionEncoding.Binary,
	"base58": UiTransactionEncoding.Base58,
	"base64": UiTransactionEncoding.Base64,
	"json": UiTransactionEncoding.Json,
	"jsonParsed": UiTransactionEncoding.JsonParsed,
	}

[ruiqic]

Hi, thanks for checking the code. How can the coverage test be fixed?

[michaelhly]

I'll fix that separately. @ruiqic, would you mind giving me push access to your forked repo? I just want to push some clean up.

[michaelhly]

LGTM! Thanks!

[ruiqic]

Thanks. I already had Allowing edits by maintainers checked but I invited you as collaborator too.