Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix special characters in branch name to avoid path error #2

Closed
wants to merge 1 commit into from

Conversation

realjck
Copy link
Contributor

@realjck realjck commented Mar 29, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix

What is the current behavior?

  • When a branch name contains a slash, it generates an error when saving the archive

Issue Number: #1

What is the new behavior?

  • Special characters in branch names (<, >, | and /) are replaced by a hyphen (-) for archive naming

Copy link

I do not accept PRs here on GitHub, as project is synced from Azure DevOps. If you have any questions, please feel free to contact me.

@github-actions github-actions bot closed this Mar 29, 2024
@michaelmsonne
Copy link
Owner

I see I should remove a task so it not will be closed automaticly..

Will fix 👍

@realjck
Copy link
Contributor Author

realjck commented Mar 29, 2024

For the fix I also added other cases for special characters other than the slash and authorized by git (brackets and pipe <> | ).
Please let me know if I need to take another action.

@realjck
Copy link
Contributor Author

realjck commented Mar 29, 2024

Furthermore, in the code, I chose to create a new variable branchNameFormatted to increase readability.
The name may of course be changed, or perhaps there is a more elegant fix.

@michaelmsonne
Copy link
Owner

Nice @realjck - I have pushed the code changes and I right now looking at the other to 👍
For now the code works, but can be I optimize it later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants