Add composer.json, so we can use wpackagist to include the plugin #11
Conversation
|
Nice. I have to check the license though, because if I add it somewhere for inclusion I'd rater use MIT or something similar. Have to check if I used any code that is not mine. |
|
Just checked. The only thing I use is guzzle (just because I am no real fan of the HTTP options wordpress provides and I needed something that was light so that I don't have to initialize all of WP for a simple image request). Currently the dist files are just dropped to this repository, in the long run it might be better to pull them using compozer. So if you are fine with it (since you are now the only other contributor to this repo), I would like to set the license to MIT. This makes distributing it with themes / modifying it for non-WP sites easier. |
|
Sure no problem with the license. It was primarily for the composer stuff, so feel free to change it. |
There was a problem hiding this comment.
@dword-design
I'm currently reworking the deployment of this plugin (and some others I made) to upload the current version to the official WP plugin directory.
While doing this, I could also add a package.json to all releases. But I don't really understand the use of this since wpackagist is adding them as well. Where do you expect this file to be added?
| .empty() | ||
| .append(jQuery('<div class="video-wrapped-play">').html(jQuery(this).attr('data-embed-play'))) | ||
| .append($('<div class="video-wrapped-play">').html($(this).attr('data-embed-play'))) |
There was a problem hiding this comment.
I know that Wordpress is using the $ shortcut for jQuery, but I'd prefer to keep the long version for compatibility.
|
Regarding the composer.json there is still the dependency of Guzzle. If you mix composer projects with pasted libraries, this leads to double definitions and incompatibilities. I manage all my PHP projects with composer. Despite that you‘re right – wpackagist creates a composer.json for you. Regarding jQuery, I think I switched to $ for convenience but it doesn‘t really change much. As you like. |
|
I don't think this will be much of a problem since I am only using this composer library for the PHP script that proxies the image from e.g. youtube. For performance reasons, I don't want to load a full Wordpress there and that was the easies way to include an universal HTTP client in this script. It should not interfere with any other WP plugin since it is never loaded while WP is loaded. |
|
@michaelzangl, any progress here? I'd love to see the |
No description provided.