Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window preview in Gnome 45 #2207

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

sergio-costas
Copy link
Collaborator

When setting the middle button click as "show window preview", the previews aren't shown. Instead, an empty rectangle appears and a lot of errors are shown in the log.

This patch fixes this.

Fix #2202

When setting the middle button click as "show window preview",
the previews aren't shown. Instead, an empty rectangle appears
and a lot of errors are shown in the log.

This patch fixes this.

Fix micheleg#2202
Copy link

@JoseExposito JoseExposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Fedora 39 + GNOME 45 and fixes the issue.

I can't comment on the code as I'm not familiar with it.

Thanks a lot for the quick fix!!!

Copy link
Collaborator

@3v1n0 3v1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @JoseExposito maybe you can check again the new version still works for you?

@JoseExposito
Copy link

@3v1n0 tested after the refactor, keeps working.

Thank you both of you for your work on the extension!

@3v1n0
Copy link
Collaborator

3v1n0 commented Apr 25, 2024

Thanks both!

@3v1n0 3v1n0 merged commit e4f1a2e into micheleg:master Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window preview doesn't work anymore
3 participants