locations: handle lack of dock manager in GetApps() #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example stack traces (taken with extra instrumentation): In the Unite extension (which then terminates): |
This method may be called in situations where there is no dock manager, so handle it gracefully, rather than letting an exception propagate. In some situations, this method may end up getting called in the context of another extension and the un-caught exception can terminate that extension.
philipl
force-pushed
the
locations-no-dockmanager
branch
from
f22e7f1
to
b42309b
Compare
|
Fixes #2297 |
|
Mhmh, the real bug is why the injection that is created https://github.com/micheleg/dash-to-dock/blob/master/docking.js#L1887C17-L1893 doesn't get disabled when the dock has been destroyed, since that's what it should happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method may be called in situations where there is no dock manager, so handle it gracefully, rather than letting an exception propagate.
In some situations, this method may end up getting called in the context of another extension and the un-caught exception can terminate that extension.