Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for decorative partial functions #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for decorative partial functions #150

wants to merge 1 commit into from

Conversation

dafu-wu
Copy link

@dafu-wu dafu-wu commented Nov 24, 2022

@micheles
Copy link
Owner

You should also add a test of the functionality inside decorator/src/tests/test.py

@dafu-wu
Copy link
Author

dafu-wu commented Nov 24, 2022

You should also add a test of the functionality inside decorator/src/tests/test.py

I made changes, could you please help me to review it

@micheles
Copy link
Owner

Looks good, but I will have time to merge this and make a new release of the decorator module only towards the end of the year.

@dafu-wu
Copy link
Author

dafu-wu commented Nov 24, 2022

Looks good, but I will have time to merge this and make a new release of the decorator module only towards the end of the year.

Ok

@dafu-wu dafu-wu mentioned this pull request Nov 27, 2022
Open
ethanschen
ethanschen approved these changes Mar 17, 2023
View reviewed changes
Copy link

@ethanschen ethanschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanschen ethanschen ethanschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dafu-wu @micheles @ethanschen