Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored default Stream catalog page size #513

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

loicgreffier
Copy link
Collaborator

No description provided.

@loicgreffier loicgreffier added the bug Something isn't working label Feb 13, 2025
@loicgreffier
Copy link
Collaborator Author

@ThomasCAI-mlv

When

ns4kafka:
  confluent-cloud:
    stream-catalog:

is not explicitely defined in the application.yml, default value is ignored and Ns4Kafka fails:

java.lang.NullPointerException: Cannot invoke "com.michelin.ns4kafka.property.ConfluentCloudProperties$StreamCatalogProperties.getPageSize()" because the return value of "com.michelin.ns4kafka.property.ConfluentCloudProperties.getStreamCatalog()" is null

Copy link
Collaborator

@ThomasCAI-mlv ThomasCAI-mlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ThomasCAI-mlv ThomasCAI-mlv merged commit 47f6e73 into master Feb 13, 2025
4 checks passed
@ThomasCAI-mlv ThomasCAI-mlv deleted the fix-missing-stream-catalog branch February 13, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants