-
Notifications
You must be signed in to change notification settings - Fork 30
WIP: Add partial resources #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,7 @@ fn numeric_id() { | |
let doc = chapter.to_jsonapi_document(); | ||
assert!(doc.is_valid()); | ||
match &doc { | ||
JsonApiDocument::Error(_) => assert!(false), | ||
JsonApiDocument::Error(_) => panic!(), | ||
JsonApiDocument::Data(x) => { | ||
assert_eq!(x.data, Some(PrimaryData::Single(Box::new(res)))); | ||
} | ||
|
@@ -120,7 +120,7 @@ fn from_jsonapi_document() { | |
|
||
// This assumes that the fixture we're using is a "valid" document with data | ||
match author_doc { | ||
JsonApiDocument::Error(_) => assert!(false), | ||
JsonApiDocument::Error(_) => panic!(), | ||
JsonApiDocument::Data(doc) => { | ||
let author = Author::from_jsonapi_document(&doc) | ||
.expect("Author should be generated from the author_doc"); | ||
|
@@ -130,3 +130,43 @@ fn from_jsonapi_document() { | |
} | ||
} | ||
} | ||
|
||
#[derive(Debug, PartialEq, Serialize, Deserialize)] | ||
struct NewAuthor { | ||
name: String, | ||
books: Vec<String>, | ||
} | ||
partial_jsonapi_model!(NewAuthor; "authors"; has many books); | ||
|
||
#[derive(Debug, PartialEq, Serialize, Deserialize)] | ||
struct NewBook { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should include a test that this model generates relationships and doesn't just smuggle things past seralisation as an attribute. |
||
title: String, | ||
first_chapter: String, | ||
chapters: Vec<String>, | ||
} | ||
partial_jsonapi_model!(NewBook; "books"; has one first_chapter; has many chapters); | ||
|
||
#[derive(Debug, PartialEq, Serialize, Deserialize)] | ||
struct NewChapter { | ||
title: String, | ||
ordering: i32, | ||
} | ||
partial_jsonapi_model!(NewChapter; "chapters"); | ||
|
||
#[test] | ||
fn to_jsonapi_document_and_back_partial() { | ||
let new_book = NewBook { | ||
title: "The Fellowship of the Ring".into(), | ||
first_chapter: "1".into(), | ||
chapters: vec!["1".into(), "2".into(), "3".into()], | ||
}; | ||
|
||
let doc = new_book.to_jsonapi_document(); | ||
let json = serde_json::to_string(&doc).unwrap(); | ||
let new_book_doc: DocumentData = serde_json::from_str(&json) | ||
.expect("Book DocumentData should be created from the book json"); | ||
let new_book_again = NewBook::from_jsonapi_document(&new_book_doc) | ||
.expect("NewBook should be generated from the new_book_doc"); | ||
|
||
assert_eq!(new_book, new_book_again); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs an implementation - presumably you should be able to build a partial resource from a full resource, though not the other way around.