-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximize and Minimize Options #7
base: master
Are you sure you want to change the base?
Conversation
Thank you very much for the PR. This is what I did.
Could you check the examples work fine again? |
Ok. I got it, the problem is the overflow config. It only works if the overflow=auto. I will try to update the style on runtime |
any update on this I'd like to make use of it but considering rolling my own. Unrelated maybe but I was wondering if we could just have slots for the title bar, I would like to add an icon and other custom buttons for various actions, but that's hard to do without replacing the titlebar |
nevermind after looking through the code I see there is a slot for title so in that case I would simple put all of my custom buttons and icon in to children of that slot. So you could so something like this
|
I'd like to weigh in and say that this functionality doesn't really belong in core code, as you can easily implement this yourself. Seems very use-case specific. |
Created Maximize and Minimize Options. Also added offset for top and right, so when maximized, you can maximize it under a toolbar for example.
Also, on every resize event, I had to call the window.resize so components, like echarts, can resize itself. I added a 1 sec timeout so the command is not dispatched everytime.