Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nandi95
Copy link

@nandi95 nandi95 commented Jun 6, 2023

As this seems to be abandoned, I will only finish up this PR if I hear back positive feedback.

@mickaelchanrion
Copy link
Owner

Hello,
Thank you for adding typings to Rolly! Once done, I will release a new version including it.

You're right, this projet is no longer in active development as I no longer use Rolly. Scroll-hijacking is a controversial practice as it means saying goodbye to great native accessibility features, IntersectionObserver, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants