Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile error in recent master #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

edap
Copy link

@edap edap commented Feb 5, 2018

Without this fix, the addon does not compile with the latest OF master version (that soon will be the new release, 0.10), this was the error

/ofxMaxim/libs/maxiGrains.h:128: error: no return statement in function returning non-void [-Werror=return-type]
virtual double play() {}

@ClaudiaMirabile
Copy link

The correction doesn't work for me:
Error C2577 'maxiGrainBase': a destructor cannot have a return type (compiling source file src\ofApp.cpp) 10_MaxigranularSynthesys

@mzed
Copy link
Collaborator

mzed commented Jul 24, 2018

Isn't the problem in the play() method, not the destructor?

@edap
Copy link
Author

edap commented Jul 24, 2018

You are right @mzed, my bad. I will test it at home and change the commit.

@rychrd
Copy link

rychrd commented Nov 2, 2018

@edap I get the same error on RPi , but not Mac...Making play() method 'pure' virtual seems to fix it, but would be good if someone could double check i've not broken something else..

class maxiGrainBase {
public:
virtual double play() = 0;
virtual ~maxiGrainBase() {}
bool finished;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants