Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed maxiEnv::adsr #64

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed maxiEnv::adsr #64

wants to merge 3 commits into from

Conversation

Seledrex
Copy link

When sustain was set to 0, maxiEnv::adsr would not function properly. With the new changes, it is now simple to create pluck sounds by setting the sustain to 0, and then adjusting decay and release. When the trigger is released, the envelope will automatically move to the next phase, allowing for rapid playing of plucked notes as well

When sustain was set to 0, maxiEnv::adsr would not function properly. With the new changes, it is now simple to create pluck sounds by setting the sustain to 0, and then adjusting decay and release. When the trigger is released, the envelope will automatically move to the next phase, allowing for rapid playing of plucked notes as well
When sustain was set to 0, maxiEnv::adsr would not function properly. With the new changes, it is now simple to create pluck sounds by setting the sustain to 0, and then adjusting decay and release. When the trigger is released, the envelope will automatically move to the next phase, allowing for rapid playing of plucked notes as well
@dfilaretti
Copy link

dfilaretti commented Nov 12, 2018

I had the same issue with maxiEnv::adsr and I found this while googling possible solutions.
The suggested change in double maxiEnv::adsr(double input, int trigger) seems to work fine, why this has never been merged? I suppose the issue is with all those spaces that have been replaced/removed?

If you want I can open a new pull request with just the needed change?

@Seledrex
Copy link
Author

Yeah, go ahead and make a new PR. I think whoever owns the repo might not be active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants