Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README_zh.md #13

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Add README_zh.md #13

wants to merge 19 commits into from

Conversation

sixg0000d
Copy link
Contributor

Translate README.md to Chinese and add Chinese demos.

@micl2e2
Copy link
Owner

micl2e2 commented Apr 27, 2024

Thanks for your contribution! Your work is so impressive that it satisfies most of the project's criteria. But there are still some parts that could have been done better:

  1. Since the pictures are directly saved as repository content, the
    size of them is very crucial. Compared to the current demo's size(928K), yours is 3.2M in total, at least 3 times larger than the EN version. Consider reducing the size by compression, less than 1M is perfect, and less than 1.5M is fine, but the larger won't be accepted. Note that the sharpness is sufficient as long as the text and other contents inside the picture can be readily seen and understood by a normal human.
  2. The zh is ambiguous. Consider adding a region code to it.
  3. Consider adding a preamble line of the translation for the following line, placed just before "Table of Contents":
    **(The translation might probably be outdated. Refer to the English version of README for the latest documentation.)**
    

@sixg0000d
Copy link
Contributor Author

Thanks for your contribution! Your work is so impressive that it satisfies most of the project's criteria. But there are still some parts that could have been done better:

  1. Since the pictures are directly saved as repository content, the
    size of them is very crucial. Compared to the current demo's size(928K), yours is 3.2M in total, at least 3 times larger than the EN version. Consider reducing the size by compression, less than 1M is perfect, and less than 1.5M is fine, but the larger won't be accepted. Note that the sharpness is sufficient as long as the text and other contents inside the picture can be readily seen and understood by a normal human.
  2. The zh is ambiguous. Consider adding a region code to it.
  3. Consider adding a preamble line of the translation for the following line, placed just before "Table of Contents":
    **(The translation might probably be outdated. Refer to the English version of README for the latest documentation.)**
    

Got it, I will improve them later.

@sixg0000d
Copy link
Contributor Author

Thanks for your contribution! Your work is so impressive that it satisfies most of the project's criteria. But there are still some parts that could have been done better:

  1. Since the pictures are directly saved as repository content, the
    size of them is very crucial. Compared to the current demo's size(928K), yours is 3.2M in total, at least 3 times larger than the EN version. Consider reducing the size by compression, less than 1M is perfect, and less than 1.5M is fine, but the larger won't be accepted. Note that the sharpness is sufficient as long as the text and other contents inside the picture can be readily seen and understood by a normal human.
  2. The zh is ambiguous. Consider adding a region code to it.
  3. Consider adding a preamble line of the translation for the following line, placed just before "Table of Contents":
    **(The translation might probably be outdated. Refer to the English version of README for the latest documentation.)**
    

I had solve these 3 problems, please review my latest commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants