Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cluster with addCluster #112

Merged
merged 15 commits into from
Jun 28, 2024
Merged

Replace cluster with addCluster #112

merged 15 commits into from
Jun 28, 2024

Conversation

thpral
Copy link
Contributor

@thpral thpral commented Apr 10, 2024

After mia PR microbiome/mia#502 renaming cluster to addCluster in the mia package, this PR replaces cluster with addCluster in the miaViz package.

@thpral thpral requested a review from TuomasBorman April 10, 2024 08:44
Copy link
Member

@antagomir antagomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me overall.

R/plotDMN.R Outdated Show resolved Hide resolved
@antagomir
Copy link
Member

Conflicts to resolve.

thpral and others added 3 commits May 22, 2024 10:59
Merge branch 'devel' of https://github.com/microbiome/miaViz into rename_cluster

# Conflicts:
#	NEWS
Copy link

codecov bot commented May 24, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@antagomir
Copy link
Member

up

@TuomasBorman TuomasBorman merged commit 27ca8d5 into devel Jun 28, 2024
1 of 3 checks passed
@TuomasBorman TuomasBorman deleted the rename_cluster branch June 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants