-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update badges #151
Merged
Merged
update badges #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have now updated microbiomeDataSets in Bioc devel. This should take a few days to go through. Version 1.13.3 |
Certain dataset was removwd in the summer. This is known problem, however, it does affext only the vignettes. that is why i did not do anything
But that is why those dataeets cannot be removed without deprecation warnings
21.9.2024 12.15 Muluh ***@***.***> kirjoitti:
improve badges. the failing bioc build is as a result of the dependence of miaViz on microbiomeDatasets. But this is resolved in our current devel.
@antagomir<https://github.com/antagomir>
…________________________________
You can view, comment on, or merge this pull request online at:
#151
Commit Summary
* b2633e3<b2633e3> Update README.md
* 2c0e8b9<2c0e8b9> Update README.md
* 8c1acf2<8c1acf2> Update README.md
File Changes
(1 file<https://github.com/microbiome/miaViz/pull/151/files>)
* M README.md<https://github.com/microbiome/miaViz/pull/151/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5> (7)
Patch Links:
* https://github.com/microbiome/miaViz/pull/151.patch
* https://github.com/microbiome/miaViz/pull/151.diff
—
Reply to this email directly, view it on GitHub<#151>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOMLFJUTMZMOKARSNOBTYRTZXU2LVAVCNFSM6AAAAABOTNLABOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DAMJQGA3DAMQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
antagomir
approved these changes
Sep 21, 2024
If @Daenarys8 can fix vignette if necessary that wuld be great |
It is already fixed, I believe. The failing happens in release of Bioc if I remember correctly. I thought that it is better to keep untouched (of course we can push to that branch also but it is easier to not). New release is in October which will solve this problem
21.9.2024 13.42 Leo Lahti ***@***.***> kirjoitti:
If @Daenarys8<https://github.com/Daenarys8> can fix vignette if necessary that wuld be great
—
Reply to this email directly, view it on GitHub<#151 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOMLFJQEVUDAVW5K6TLDJUDZXVERBAVCNFSM6AAAAABOTNLABOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGEZTSNZYG4>.
You are receiving this because you commented.Message ID: ***@***.***>
|
TuomasBorman
reviewed
Oct 2, 2024
TuomasBorman
reviewed
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve badges. the failing bioc build is as a result of the dependence of
miaViz
onmicrobiomeDatasets
. But this is resolved in our current devel.@antagomir