Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build debug information alongside non-debug builds. #89

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Build debug information alongside non-debug builds. #89

wants to merge 2 commits into from

Conversation

microbit-matt-hillsdon
Copy link
Contributor

We should then be able to use it in Chrome's Wasm/DWARF debug tooling to understand production issues.

@netlify
Copy link

netlify bot commented Nov 1, 2022 •
edited
Loading

✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit aa1b3ea
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/6368cc4c0ff408000966d626
😎 Deploy Preview https://deploy-preview-89--distracted-dubinsky-fd8a42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@microbit-matt-hillsdon
Copy link
Contributor Author

Needs me to check file size impact. This should be negligible.

@microbit-matt-hillsdon
Copy link
Contributor Author

There's a 16% increase in the size of the Wasm, presumably for this logged reason:

emcc: warning: running limited binaryen optimizations because DWARF info requested (or indirectly required) [-Wlimited-postlink-optimizations]

A full debug build is a 290% increase.

I'll confirm it's actually debuggable in Chrome and perhaps look at size wins elsewhere.

@microbit-matt-hillsdon
Copy link
Contributor Author

You can win 2% back overall by tweaking the JavaScript build but still a 10% overall increase.

I think we'll need to live with this or something similar at least for a while so we can understand the issues we see logged.

@microbit-matt-hillsdon microbit-matt-hillsdon mentioned this pull request Nov 2, 2022
Open
microbit-matt-hillsdon added a commit to microbit-foundation/python-editor-v3 that referenced this pull request Nov 3, 2022
@microbit-matt-hillsdon
Test branch for sim change.
ed47a4d 
See microbit-foundation/micropython-microbit-v2-simulator#89

Do not merge.
@microbit-matt-hillsdon
Build debug information alongside non-debug builds.
aba12ca 
We should then be able to use it in Chrome's Wasm/DWARF debug tooling to
understand production issues.

This results in a 12% size increase. Win ~2% back by minifying the
JavaScript.
@microbit-matt-hillsdon
Copy link
Contributor Author

We should actually publish the JS source map:

DevTools failed to load source map: Could not load content for https://review-python-simulator.usermbit.org/separate-dwarf/build/simulator.js.map: HTTP error: status code 403, net::ERR_HTTP_RESPONSE_CODE_FAILURE

@microbit-matt-hillsdon
Copy link
Contributor Author

In-editor preview:

https://review-python-editor-v3.microbit.org/separate-dwarf/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@microbit-matt-hillsdon