Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codal_port/microbit_soundeffect: Use CODAL-provided constants for fx. #218

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

dpgeorge
Copy link
Collaborator

@dpgeorge dpgeorge commented Aug 21, 2024

To address #155 (comment)

Edit: It's not possible to include the CODAL header file that defines these constants because that header file is C++. So instead just add comments.

@dpgeorge dpgeorge force-pushed the microbit-soundeffect-update-default-fx-constants branch from a0ac7dd to 6eb46a3 Compare August 21, 2024 02:07
@microbit-carlos
Copy link
Contributor

microbit-carlos commented Aug 21, 2024

Thanks Damien!
Can we also add some compile time checks in the MicroPython C++ CODAL-abstraction files to check that the CODAL values haven't changed between releases?

It's not possible to include the CODAL header file that defines these
constants because that header file is C++.

Signed-off-by: Damien George <[email protected]>
@dpgeorge dpgeorge force-pushed the microbit-soundeffect-update-default-fx-constants branch from 6eb46a3 to 251bd63 Compare August 22, 2024 01:13
@dpgeorge
Copy link
Collaborator Author

Updated to add static asserts.

Copy link
Contributor

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Damien!

@dpgeorge dpgeorge merged commit 251bd63 into master Aug 26, 2024
6 checks passed
@dpgeorge dpgeorge deleted the microbit-soundeffect-update-default-fx-constants branch August 26, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants