Make DistributionStatisticConfig extensible #3854
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -497,7 +525,7 @@ private void validate(DistributionStatisticConfig distributionStatisticConfig) { | |||
| } | |||
| } | |||
|
|
|||
| private static void rejectConfig(String msg) { | |||
| protected static void rejectConfig(String msg) { | |||
There was a problem hiding this comment.
DoNotCallSuggester: Methods that always throw an exception should be annotated with @DonotCall to prevent calls at compilation time vs. at runtime (note that adding @DonotCall will break any existing callers of this API).
| protected static void rejectConfig(String msg) { | |
| @DoNotCall("Always throws io.micrometer.core.instrument.config.InvalidConfigurationException") protected static void rejectConfig(String msg) { |
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/micrometer/3854.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/micrometer/3854.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
|
Let's discuss this on the issue first before we would talk about what is needed to implement it. |
| public DistributionStatisticConfig() { | ||
| } | ||
|
|
||
| public DistributionStatisticConfig(DistributionStatisticConfig original) { |
There was a problem hiding this comment.
I'm not sure I getting why this is needed, should not this be the concern of merge instead?
There was a problem hiding this comment.
I thought it's the only way that that the subclass's constructor can copy all fields to a subclass instance, when merging
| config = new DistributionStatisticConfig(); | ||
| } | ||
|
|
||
| protected Builder(DistributionStatisticConfig config) { |
There was a problem hiding this comment.
I'm not sure I get this either a Builder should create an instance of DistributionStatisticConfig, not receive one.
| return new SubBuilder(new SubDistributionStatisticConfig()); | ||
| } | ||
|
|
||
| public static class SubBuilder extends Builder { |
There was a problem hiding this comment.
Is this why you need to receive a DistributionStatisticConfig in DistributionStatisticConfig.Builder?
I don't think SubDistributionStatisticConfig.Builder should extend DistributionStatisticConfig.Builder.
There was a problem hiding this comment.
Yes. Which way would you recommend?
|
@jonatan-ivanov thank you for the comments. This PoC was meant to (1) convey what I want to do and (2) show that it's doable without breaking binary compatibility. |
Fixes #3848