Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation when default language is unavailable #684

Merged
merged 1 commit into from
May 13, 2024

Commits on May 10, 2024

  1. Fix documentation when default language is unavailable

    When a user views the documentation and clicks on a multi-lang snippet to view a specific language, we store that language in local-storage
    
    So when they go to view another documentation doc, we remember what the language was, and select that one.
    
    So someone who had selected Kotlin, sees Kotlin snippets when they go back later.
    
    This had a bug in it. Sometimes when we add a multi-lang snippet we may only have a selection of languages covered in the tested source code.
    The issue is that when someone who has selected Kotlin previously lands on a page with a missing Kotlin snippet, they see no snippet as all are hidden.
    
    This PR introduces a new method which checks if a snippet group is all hidden, and if it is, it forces the first one to be visible
    timyates committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2b91d2f View commit details
    Browse the repository at this point in the history