-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix identification getters / setters for properties with second upper case symbol. For example eTemperature #10130
base: 5.0.x
Are you sure you want to change the base?
Conversation
@graemerocher @dstepanov I've known about this problem for a long time, but usually got around it by simply renaming the fields. It's time to fix this bug |
unlikely to happen before 5.x |
This change might lead to wrong interpretation of the method |
@dstepanov your sample is invalid: in your method name you have 2 chars with lower case. This is contrary to Java naming conventions. Therefore the given method name will simply be ignored because it is not a getter. The only naming restriction in Java is this: for names like public String getMfIeld() {
...
}
public void setMfIeld(...) {
...
} But even this situation has no solution: according to Java convention, class attribute names must begin with a lowercase letter, so a field called But the name |
b8b4bd9
to
542d97c
Compare
@dstepanov I want to say that now only one case of a correct getter name is not processed: When the first letter is lowercase, but the second letter is uppercase, that is, the first two letters in lowercase cannot be in the getter name. Remember, I described to you the rules for naming getters and setters, in sufficient detail and identified 3 rules. So, then I only corrected the keyword with the |
@graemerocher It doesn't matter. The main thing is, don’t forget about this fix. As I understand it, version 5 will be released no earlier than in 3 years |
542d97c
to
bfcaa61
Compare
bfcaa61
to
94c45d4
Compare
94c45d4
to
89aa2a3
Compare
… case symbol. For example eTemperature
89aa2a3
to
4426d7d
Compare
Related issue micronaut-projects/micronaut-openapi#1226