Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log decompression exception #10323

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Don't log decompression exception #10323

merged 1 commit into from
Jan 4, 2024

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Jan 4, 2024

Decompression errors should be treated as DEBUG to prevent log spam.

I've also copied over some other fuzz tests from #10131. None of them were an issue except one caused by a bug in netty EmbeddedChannel ( netty/netty#13730 ).

Decompression errors should be treated as DEBUG to prevent log spam.

I've also copied over some other fuzz tests from #10131. None of them were an issue except one caused by a bug in netty EmbeddedChannel ( netty/netty#13730 ).
@yawkat yawkat added the type: bug Something isn't working label Jan 4, 2024
@yawkat yawkat added this to the 4.3.0 milestone Jan 4, 2024
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the Sonar issues can be addressed (or are even an issue)

@yawkat yawkat merged commit 18f3786 into 4.3.x Jan 4, 2024
14 of 15 checks passed
@yawkat yawkat deleted the decompress-exc branch January 4, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants