Properly handle missing classes in metadata + precalculated requirements

[dstepanov]

Fixes #10931

[dstepanov]

Newly generated code:

static {
        $ANNOTATION_METADATA = new AnnotationMetadataHierarchy(new AnnotationMetadata[]{new DefaultAnnotationMetadata(Map.of("io.micronaut.context.annotation.Factory", Map.of(), "jakarta.inject.Singleton", Map.of()), Map.of("io.micronaut.context.annotation.DefaultScope", Map.of("value", $micronaut_load_class_value_0())), Map.of("io.micronaut.context.annotation.DefaultScope", Map.of("value", $micronaut_load_class_value_0())), Map.of("io.micronaut.context.annotation.Factory", Map.of(), "jakarta.inject.Singleton", Map.of()), Map.of("io.micronaut.context.annotation.DefaultScope", List.of("io.micronaut.context.annotation.Factory")), false, false), new DefaultAnnotationMetadata(Map.of("io.micronaut.context.annotation.Bean", Map.of(), "io.micronaut.context.annotation.Requirements", Map.of("value", new AnnotationValue[]{new AnnotationValue("io.micronaut.context.annotation.Requires", Map.of("beans", new AnnotationClassValue[]{$micronaut_load_class_value_1()}, "missingBeans", new AnnotationClassValue[]{$micronaut_load_class_value_2()}), AnnotationMetadataSupport.ANNOTATION_DEFAULT_VALUES_PROVIDER)})), Map.of(), Map.of(), Map.of("io.micronaut.context.annotation.Bean", Map.of(), "io.micronaut.context.annotation.Requirements", Map.of("value", new AnnotationValue[]{new AnnotationValue("io.micronaut.context.annotation.Requires", Map.of("beans", new AnnotationClassValue[]{$micronaut_load_class_value_1()}, "missingBeans", new AnnotationClassValue[]{$micronaut_load_class_value_2()}), AnnotationMetadataSupport.ANNOTATION_DEFAULT_VALUES_PROVIDER)})), Map.of(), false, false)});

        try {
            $CONSTRUCTOR = new AbstractInitializableBeanDefinition.MethodReference(AFactory.class, "a", new Argument[]{Argument.of(X.class, "x")}, new DefaultAnnotationMetadata(Map.of("io.micronaut.context.annotation.Bean", Map.of(), "io.micronaut.context.annotation.Factory", Map.of(), "io.micronaut.context.annotation.Requirements", Map.of("value", new AnnotationValue[]{new AnnotationValue("io.micronaut.context.annotation.Requires", Map.of("beans", new AnnotationClassValue[]{$micronaut_load_class_value_1()}, "missingBeans", new AnnotationClassValue[]{$micronaut_load_class_value_2()}), AnnotationMetadataSupport.ANNOTATION_DEFAULT_VALUES_PROVIDER)}), "jakarta.inject.Singleton", Map.of()), Map.of("io.micronaut.context.annotation.DefaultScope", Map.of("value", $micronaut_load_class_value_0())), Map.of("io.micronaut.context.annotation.DefaultScope", Map.of("value", $micronaut_load_class_value_0())), Map.of("io.micronaut.context.annotation.Bean", Map.of(), "io.micronaut.context.annotation.Factory", Map.of(), "io.micronaut.context.annotation.Requirements", Map.of("value", new AnnotationValue[]{new AnnotationValue("io.micronaut.context.annotation.Requires", Map.of("beans", new AnnotationClassValue[]{$micronaut_load_class_value_1()}, "missingBeans", new AnnotationClassValue[]{$micronaut_load_class_value_2()}), AnnotationMetadataSupport.ANNOTATION_DEFAULT_VALUES_PROVIDER)}), "jakarta.inject.Singleton", Map.of()), Map.of("io.micronaut.context.annotation.DefaultScope", List.of("io.micronaut.context.annotation.Factory")), false, false));
        } catch (Throwable var0) {
            $FAILURE = var0;
            $CONSTRUCTOR = null;
        }

        $INFO = new AbstractInitializableBeanDefinition.PrecalculatedInfo(Optional.empty(), false, false, false, false, false, false, false, false);
        $PRE_CONDITIONS = new Condition[]{new MatchesPresenceOfClassesCondition(new AnnotationClassValue[]{$micronaut_load_class_value_1()})};
        $POST_CONDITIONS = new Condition[]{new MatchesPresenceOfBeansCondition(new AnnotationClassValue[]{$micronaut_load_class_value_1()}), new MatchesAbsenseOfBeansCondition(new AnnotationClassValue[]{$micronaut_load_class_value_2()})};
    }

[graemerocher]

add nullability annotations

[dstepanov]

What kind of nullability annotations?

[graemerocher]

can you change this slightly to try lookup this constructor otherwise if not there fallback to the other constructor. Otherwise we will hit binary compatibility issues for all the modules again.

[dstepanov]

This will not break anything, that's the new super constructor. We have some modules that have been compiled with previous version and tests are passing.

[graemerocher]

yes but if there is an old version of micronaut-inject then the lookup will fail which means we will have to release new versions of every minor release

[dstepanov]

How is it possible to have an older version of micronaut-inject? Inject and core-processor should always come with the same version.

[graemerocher]

see micronaut-projects/micronaut-platform#1075

[graemerocher]

there seem to be some test failures

[graemerocher]

@dstepanov pls address the sonar stuff before merging

[sonarcloud]

Quality Gate failed

Failed conditions
63.6% Coverage on New Code (required ≥ 70%)
6 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint