Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pcap logging for netty HTTP client #11117

Open
wants to merge 1 commit into
base: 4.7.x
Choose a base branch
from
Open

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Aug 26, 2024

The server has supported this for a long time. This PR adds the same feature for client logging. The code is very similar, and the test is basically copied.

The server has supported this for a long time. This PR adds the same feature for client logging. The code is very similar, and the test is basically copied.
@yawkat yawkat added the type: improvement A minor improvement to an existing feature label Aug 26, 2024
@yawkat yawkat added this to the 4.7.0 milestone Aug 26, 2024
Copy link

sonarcloud bot commented Aug 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
59.0% Coverage on New Code (required ≥ 70%)
14.2% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants