imp: MethodRoute stringValues behave as getValues #9552
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
| } | ||
|
|
||
| @NonNull | ||
| private String[] firstNotEmptyStringValuesInHierarchy(@NonNull String annotation, @NonNull String member) { |
There was a problem hiding this comment.
I think the previous code is more correct, all the values are aggregated.
There was a problem hiding this comment.
Please note that with:
@Controller("/example")
@RolesAllowed("isAuthenticated()")
static class ExampleController {
@Get("/admin")
@RolesAllowed({"ROLE_ADMIN", "ROLE_X"})
void admin(HttpRequest<?> request) {
}
old stringValues returns "ROLE_ADMIN", "ROLE_X", "isAuthenticated()" while getValues returns "ROLE_ADMIN", "ROLE_X". The latter looks correct to me.
There was a problem hiding this comment.
There may be some behaviour inconsistency here, but this change has the potential to break a lot of things. I don't think we should be merging this 2 days before GA
There was a problem hiding this comment.
I am ok not merging it. Do you want me to target 5.0.x as the PR base?
There was a problem hiding this comment.
@sdelamo You might need to modify the code that reads the values to only take method annotation metadata
|
It is too late to make a change this big IMO |
No description provided.