fixes #9577 #9580
fixes #9577 #9580
Conversation
| @@ -176,6 +177,9 @@ protected TypeConverter<Map, Object> mapToObjectConverter() { | |||
| } | |||
| ArgumentBinder binder = this.beanPropertyBinder.get(); | |||
| ArgumentBinder.BindingResult result = binder.bind(conversionContext, correctKeys(map)); | |||
| conversionContext.getLastError().ifPresent(error -> { | |||
| throw new ConversionErrorException(conversionContext.getArgument(), error); | |||
| }); | |||
There was a problem hiding this comment.
this will modify universally for all type conversions that use this type converter which is a breaking change.
We need to modify only the place where the conversion happens to throw this error
There was a problem hiding this comment.
@n0tl3ss can you address @graemerocher PR feedback? thanks.
There was a problem hiding this comment.
@sdelamo Offline I told Graeme that I think this is the right place where I should expect error to be thrown. He told me that he will take a look how better to do it.
|
Kudos, SonarCloud Quality Gate passed! |
|
|
|
|
ConversionErrorExceptionwill be thrown.Message from a provided example: