Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: positional parameters for Micronaut Data JPA #1824

Open
wants to merge 1 commit into
base: 4.7.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package io.micronaut.data.hibernate.querygroupby

import io.micronaut.context.annotation.Property
import io.micronaut.data.hibernate.entities.MicronautProject
import io.micronaut.test.extensions.spock.annotation.MicronautTest
import jakarta.inject.Inject
import spock.lang.PendingFeature
import spock.lang.Specification

@MicronautTest(startApplication = false, packages = "io.micronaut.data.hibernate.entities")
@Property(name = "datasources.default.name", value = "mydb")
@Property(name = 'jpa.default.properties.hibernate.hbm2ddl.auto', value = 'create-drop')
class ProjecttRepositorySpec extends Specification {

@Inject
MicronautProjectRepository projectRepository

@PendingFeature
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with:

1 == projectRepository.findWithNameAndDescriptionPositionalBind("P2", "Project 2").size()
     |                 |
     |                 org.hibernate.QueryException: Ordinal parameter not bound : 2
     |                 	at org.hibernate.query.internal.QueryParameterBindingsImpl.verifyParametersBound(QueryParameterBindingsImpl.java:214)
     |                 	at org.hibernate.query.internal.AbstractProducedQuery.beforeQuery(AbstractProducedQuery.java:1511)
     |                 	at org.hibernate.query.internal.AbstractProducedQuery.list(AbstractProducedQuery.java:1615)
     |                 	at io.micronaut.data.hibernate.operations.HibernateJpaOperations$ListResultCollector.collect(HibernateJpaOperations.java:531)
     |                 	at io.micronaut.data.hibernate.operations.HibernateJpaOperations$ListResultCollector.collect(HibernateJpaOperations.java:520)
     |                 	at io.micronaut.data.hibernate.operations.AbstractHibernateOperations.collectResults(AbstractHibernateOperations.java:365)
     |                 	at io.micronaut.data.hibernate.operations.AbstractHibernateOperations.collectFindAll(AbstractHibernateOperations.java:306)

void "@Query with positional parameters"() {
given:
MicronautProject p1 = projectRepository.save(new MicronautProject("P1", "Project 1", "Description of Project 1"))
MicronautProject p2 = projectRepository.save(new MicronautProject("P2", "Project 2", "Description of Project 2"))
MicronautProject p3 = projectRepository.save(new MicronautProject("P3", "Project 3", "Description of Project 3"))

expect:
1 == projectRepository.findWithNameAndDescriptionPositionalBind("P2", "Project 2").size()

cleanup:
projectRepository.delete(p3)
projectRepository.delete(p2)
projectRepository.delete(p1)
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
package io.micronaut.data.hibernate.entities;

import javax.persistence.CascadeType;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.FetchType;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.OneToMany;
import java.util.HashSet;
import java.util.Objects;
import java.util.Set;

@Entity
public class MicronautProject {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;
@Column(unique = true, nullable = false, updatable = false)
private String code;
private String name;
private String description;
@OneToMany(mappedBy = "project", orphanRemoval = true, fetch = FetchType.EAGER, cascade = CascadeType.ALL)
private Set<MicronautTask> tasks = new HashSet<>();
public MicronautProject() {
}

public MicronautProject(String code, String name, String description) {
this.code = code;
this.name = name;
this.description = description;
}

@Override
public int hashCode() {
return Objects.hashCode(code);
}
@Override
public boolean equals(Object obj) {
if (this == obj)
return true;
if (obj == null)
return false;
if (getClass() != obj.getClass())
return false;
MicronautProject other = (MicronautProject) obj;
if (code == null) {
if (other.code != null)
return false;
} else if (!code.equals(other.code))
return false;
return true;
}

public Long getId() {
return id;
}

public void setId(Long id) {
this.id = id;
}

public String getCode() {
return code;
}

public void setCode(String code) {
this.code = code;
}

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}

public String getDescription() {
return description;
}

public void setDescription(String description) {
this.description = description;
}

public Set<MicronautTask> getTasks() {
return tasks;
}

public void setTasks(Set<MicronautTask> tasks) {
this.tasks = tasks;
}

@Override
public String toString() {
return "Project [id=" + id + ", code=" + code + ", name=" + name + ", description=" + description + "]";
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
package io.micronaut.data.hibernate.entities;

import io.micronaut.data.hibernate.querygroupby.TaskStatus;

import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.ManyToOne;
import java.time.LocalDate;
import java.util.Objects;
import java.util.UUID;

@Entity
public class MicronautTask {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;
@Column(unique = true, nullable = false, updatable = false)
private String uuid = UUID.randomUUID().toString();
private String name;
private String description;
private LocalDate dueDate;

private TaskStatus status;

@ManyToOne(optional = false)
private MicronautProject project;


public MicronautTask() {
}
public MicronautTask(String name, String description, LocalDate dueDate, MicronautProject project) {
this(name, description, dueDate, project, TaskStatus.TO_DO);
}

public MicronautTask(String name, String description, LocalDate dueDate, MicronautProject project, TaskStatus status) {
this.name = name;
this.description = description;
this.dueDate = dueDate;
this.status = status;
this.project = project;
}

@Override
public boolean equals(Object obj) {
if (this == obj)
return true;
if (obj == null)
return false;
if (getClass() != obj.getClass())
return false;
MicronautTask other = (MicronautTask) obj;
if (uuid == null) {
if (other.uuid != null)
return false;
} else if (!uuid.equals(other.uuid))
return false;
return true;
}
@Override
public int hashCode() {
return Objects.hash(uuid);
}


public Long getId() {
return id;
}

public void setId(Long id) {
this.id = id;
}

public String getUuid() {
return uuid;
}

public void setUuid(String uuid) {
this.uuid = uuid;
}

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}

public String getDescription() {
return description;
}

public void setDescription(String description) {
this.description = description;
}

public LocalDate getDueDate() {
return dueDate;
}

public void setDueDate(LocalDate dueDate) {
this.dueDate = dueDate;
}

public TaskStatus getStatus() {
return status;
}

public void setStatus(TaskStatus status) {
this.status = status;
}

public MicronautProject getProject() {
return project;
}

public void setProject(MicronautProject project) {
this.project = project;
}


@Override
public String toString() {
return "Task [id=" + id + ", name=" + name + ", description=" + description + ", dueDate=" + dueDate + ", status=" + status + ", project=" + project + "]";
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package io.micronaut.data.hibernate.querygroupby;

import io.micronaut.data.annotation.Query;
import io.micronaut.data.annotation.Repository;
import io.micronaut.data.hibernate.entities.MicronautProject;
import io.micronaut.data.repository.CrudRepository;

import java.util.List;

@Repository
public interface MicronautProjectRepository extends CrudRepository<MicronautProject, Long> {
@Query("select p from MicronautProject p where p.name=?1 and p.description=?2")
List<MicronautProject> findWithNameAndDescriptionPositionalBind(String name, String description);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package io.micronaut.data.hibernate.querygroupby;

public enum TaskStatus {
TO_DO("To Do"),
IN_PROGRESS("In Progress"),
ON_HOLD("On Hold"),
DONE("Done");
private final String label;

private TaskStatus(String label) {
this.label = label;
}
public String getLabel() {
return label;
}
}