Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subquery Criteria API #3116

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Support subquery Criteria API #3116

merged 2 commits into from
Sep 11, 2024

Conversation

dstepanov
Copy link
Contributor

First step to support pagination with JOINs

@dstepanov dstepanov added the type: improvement A minor improvement to an existing feature label Sep 10, 2024
@dstepanov dstepanov marked this pull request as ready for review September 10, 2024 14:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.1% Coverage on New Code (required ≥ 70%)
5 New Critical Issues (required ≤ 0)
1 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dstepanov dstepanov merged commit a05fe25 into 4.10.x Sep 11, 2024
52 of 53 checks passed
@dstepanov dstepanov deleted the subq branch September 11, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radovanradic radovanradic radovanradic approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstepanov @graemerocher @radovanradic