Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converter on many-to-many table #3145

Open
wants to merge 1 commit into
base: 4.9.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package io.micronaut.data.jdbc.h2.remap;

import io.micronaut.data.annotation.Id;
import io.micronaut.data.annotation.MappedEntity;
import io.micronaut.data.annotation.Relation;

import java.util.List;
import java.util.UUID;

import static io.micronaut.data.annotation.Relation.Cascade.ALL;
import static io.micronaut.data.annotation.Relation.Kind.MANY_TO_MANY;

@MappedEntity("att_course")
record Course(

@Id
UUID id,

String name,

@Relation(value = MANY_TO_MANY, mappedBy = "courses", cascade = ALL)
List<Student> students
) {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package io.micronaut.data.jdbc.h2.remap;

import io.micronaut.data.annotation.Join;
import io.micronaut.data.jdbc.annotation.JdbcRepository;
import io.micronaut.data.model.query.builder.sql.Dialect;
import io.micronaut.data.repository.CrudRepository;

import java.util.List;
import java.util.UUID;

@JdbcRepository(dialect = Dialect.H2)
interface CourseRepository extends CrudRepository<Course, UUID> {

@Join("students")
List<Student> findStudentsById(UUID id);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
package io.micronaut.data.jdbc.h2.remap

import io.micronaut.data.jdbc.h2.H2DBProperties
import io.micronaut.test.extensions.spock.annotation.MicronautTest
import jakarta.inject.Inject
import spock.lang.Specification

@H2DBProperties
@MicronautTest
class ManyToManyAttributeSpec extends Specification {

@Inject
CourseRepository courseRepository
@Inject
StudentRepository studentRepository

def "works - should create a student"() {
when:
Student student = new Student(
new StudentId(UUID.randomUUID()),
"test",
List.of()
)
studentRepository.save(student)
then:
studentRepository.findById(student.id()).get() == student
}

def "should find students attending a course"() {
when:
Course course = new Course(
UUID.randomUUID(),
"computer science",
List.of()
)
courseRepository.save(course)
// create a new student and join the existing course
Student student = new Student(
new StudentId(UUID.randomUUID()),
"test",
List.of(course)
)
studentRepository.save(student) == student

then:
// we should now be able to find the student that attends the course
courseRepository.findStudentsById(course.id())[0].name() == student.name()
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package io.micronaut.data.jdbc.h2.remap;

import io.micronaut.data.annotation.Id;
import io.micronaut.data.annotation.MappedEntity;
import io.micronaut.data.annotation.MappedProperty;
import io.micronaut.data.annotation.Relation;
import io.micronaut.data.model.DataType;

import java.util.List;

import static io.micronaut.data.annotation.Relation.Cascade.ALL;
import static io.micronaut.data.annotation.Relation.Kind.MANY_TO_MANY;

@MappedEntity("att_student")
record Student(

@Id
@MappedProperty(converter = StudentIdAttributeConverter.class, type = DataType.UUID)
StudentId id,

String name,

@Relation(value = MANY_TO_MANY, cascade = ALL)
List<Course> courses
) {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package io.micronaut.data.jdbc.h2.remap;

import io.micronaut.core.convert.ConversionContext;
import io.micronaut.data.model.runtime.convert.AttributeConverter;
import jakarta.inject.Singleton;

import java.util.UUID;

record StudentId(UUID id) {
}

@Singleton
class StudentIdAttributeConverter implements AttributeConverter<StudentId, UUID> {
public UUID convertToPersistedValue(StudentId entityValue, ConversionContext context) {
return entityValue.id();
}

public StudentId convertToEntityValue(UUID persistedValue, ConversionContext context) {
return new StudentId(persistedValue);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package io.micronaut.data.jdbc.h2.remap;

import io.micronaut.data.jdbc.annotation.JdbcRepository;
import io.micronaut.data.model.query.builder.sql.Dialect;
import io.micronaut.data.repository.CrudRepository;

@JdbcRepository(dialect = Dialect.H2)
interface StudentRepository extends CrudRepository<Student, StudentId> {
}
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
import java.util.function.Supplier;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;

/**
* Default implementation of {@link MongoStoredQuery}.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import io.micronaut.aop.MethodInvocationContext;
import io.micronaut.context.ApplicationContextProvider;
import io.micronaut.context.BeanContext;
import io.micronaut.core.annotation.AnnotationClassValue;
import io.micronaut.core.annotation.AnnotationMetadata;
import io.micronaut.core.annotation.Internal;
import io.micronaut.core.annotation.NonNull;
Expand All @@ -26,6 +27,7 @@
import io.micronaut.data.annotation.AutoPopulated;
import io.micronaut.data.annotation.MappedProperty;
import io.micronaut.data.annotation.Repository;
import io.micronaut.data.annotation.TypeDef;
import io.micronaut.data.exceptions.DataAccessException;
import io.micronaut.data.model.Association;
import io.micronaut.data.model.DataType;
Expand Down Expand Up @@ -399,6 +401,16 @@ public JsonDataType getJsonDataType() {
return property.getKey().getJsonDataType();
}

@Override
public Class<?> getParameterConverterClass() {
return property.getKey()
.getAnnotationMetadata()
.getAnnotation(TypeDef.class)
.annotationClassValue("converter")
.flatMap(AnnotationClassValue::getType)
.orElse(null);
}

@Override
public Object getValue() {
return property.getValue();
Expand Down Expand Up @@ -427,6 +439,16 @@ public JsonDataType getJsonDataType() {
public String[] getPropertyPath() {
return pp.getArrayPath();
}

@Override
public Class<?> getParameterConverterClass() {
return pp.getProperty()
.getAnnotationMetadata()
.getAnnotation(TypeDef.class)
.annotationClassValue("converter")
.flatMap(AnnotationClassValue::getType)
.orElse(null);
}
});
}

Expand Down
Loading