FlywayConfiguration parameters configuration #450
Conversation
|
|
| @@ -53,6 +57,7 @@ public class FlywayConfigurationProperties implements Toggleable { | |||
| private String url; | |||
| private String user; | |||
| private String password; | |||
| private Map<String, String> properties = new Hashtable<>(); | |||
There was a problem hiding this comment.
why HashTable? This will be a singleton which will be used only on startup. It does not need to support synchronisation.
There was a problem hiding this comment.
If we don't want to use HashMap, I think we should use https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html
There was a problem hiding this comment.
What's the Base Java version for Micronaut Flyway ?
There was a problem hiding this comment.
Can I switch this to Map.of() instead?
There was a problem hiding this comment.
I have changed this to HashMap 910c8b2
| @@ -182,4 +187,24 @@ public boolean hasAlternativeDatabaseConfiguration() { | |||
| public FluentConfiguration getFluentConfiguration() { | |||
| return fluentConfiguration; | |||
| } | |||
|
|
|||
| /** | |||
| * Sets extra properties to be applied on configuration. | |||
There was a problem hiding this comment.
The java doc from Flyway FluentConfiguration it says Property names are documented in the flyway maven plugin. @driverpt do you have link to those properties that we could add to the javadoc here?
There was a problem hiding this comment.
I think this is what you're looking for: https://documentation.red-gate.com/fd/parameters-184127474.html
There was a problem hiding this comment.
I have improved the javadoc c475adc
There was a problem hiding this comment.
I have also added an example in the docs 1a56988
Fixes #442