Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native image args windows #1151

Open
wants to merge 7 commits into
base: 4.6.x
Choose a base branch
from
Open

Native image args windows #1151

wants to merge 7 commits into from

Conversation

houcine7
Copy link

@houcine7 houcine7 commented Jul 8, 2024

  • a temporary fix for spaces introduced by native:wrtie-args-file.
  • fix split regex that makes container fails to start.
  • fix argument parsing in windows env.

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alvarosanchez
Copy link
Member

As discussed offline, this needs to be fixed upstream: https://github.com/graalvm/native-build-tools/blob/master/native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/WriteArgsFileMojo.java

@houcine7 houcine7 marked this pull request as ready for review August 7, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosanchez alvarosanchez Awaiting requested review from alvarosanchez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@houcine7 @CLAassistant @alvarosanchez